*: partial deposits bugfixes #2951
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
+ Coverage 54.10% 54.12% +0.02%
==========================================
Files 194 194
Lines 27380 27399 +19
==========================================
+ Hits 14815 14831 +16
- Misses 10814 10815 +1
- Partials 1751 1753 +2 ☔ View full report in Codecov by Sentry. |
| @@ -38,6 +38,13 @@ func WithVersion(version string) func(*Definition) { | |||
| } | |||
| } | |||
|
|
|||
| // WithDKGAlgorithm returns an option to set a non-default DKG algorithm in a new definition. | |||
| func WithDKGAlgorithm(algorithm string) func(*Definition) { | |||
There was a problem hiding this comment.
why is this needed? we only support one dkg algo atm
There was a problem hiding this comment.
In createdkg.go it populates opts.. which we need to extend WithVersion.
https://github.com/ObolNetwork/charon/pull/2951/files#diff-0393f2244459468817c0da0434f1c1248cdd33fc03ff408fd27ff42ce9cbbe76R127
There was a problem hiding this comment.
but why do we need to populate the dkg algorithm?
There was a problem hiding this comment.
I think this is to respect the given configuration. I believe the implementation assumes different algorithms passed from the config. If you think this is odd, then we can have a ticket to remove this field from the config entirely.
pinebit
added
the
merge when ready
Several fixes for bugs identified in partial deposits implementation.
Plus, a few improvements to prevent using partial deposits for unsupported lock version.
category: bug
ticket: none