core/aggsigdb: refactor MemDB #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce MemDBV2: instead of relying on a complex system based on channels and read/write queries, simply store objects in a `sync/map`. Simpler to read and potentially faster in systems in which there's a high rate of goroutine contention. Add the `aggsigdb_v2` feature flag to enable/disable this feature.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2950 +/- ##
==========================================
+ Coverage 54.10% 54.24% +0.13%
==========================================
Files 194 195 +1
Lines 27380 27500 +120
==========================================
+ Hits 14815 14916 +101
- Misses 10814 10826 +12
- Partials 1751 1758 +7 ☔ View full report in Codecov by Sentry. |
pinebit
reviewed
Mar 11, 2024
pinebit
reviewed
Mar 11, 2024
pinebit
reviewed
Mar 11, 2024
|
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce MemDBV2: instead of relying on a complex system based on channels and read/write queries, simply store objects in a
sync/map.Simpler to read and potentially faster in systems in which there's a high rate of goroutine contention.
Add the
aggsigdb_v2feature flag to enable/disable this feature.category: refactor
ticket: #1951
feature_flag: aggsigdb_v2