Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: revert new v3 endpoint work #2939

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Mar 5, 2024

Reverted all recent v3 endpoint work (that needed go-eth2-client fork with UniversalProposal).

This piece: #2885 shall remain present.

category: misc
ticket: none

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
48.5% Duplication on New Code (required ≤ 30%)

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 75.49020% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 53.63%. Comparing base (53979d1) to head (51c286e).

Files Patch % Lines
testutil/validatormock/propose.go 65.07% 16 Missing and 6 partials ⚠️
core/fetcher/fetcher.go 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
+ Coverage   53.59%   53.63%   +0.04%     
==========================================
  Files         202      202              
  Lines       28864    28531     -333     
==========================================
- Hits        15469    15303     -166     
+ Misses      11439    11318     -121     
+ Partials     1956     1910      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 5, 2024
@obol-bulldozer obol-bulldozer bot merged commit 4dfaed8 into main Mar 5, 2024
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/revert-v3-work branch March 5, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants