cluster: remove todos #2915
Merged
cluster: remove todos #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinebit
approved these changes
Feb 28, 2024
xenowits
commented
Feb 28, 2024
| @@ -138,7 +138,6 @@ func hashDefinitionLegacy(d Definition, hh ssz.HashWalker, configOnly bool) erro | |||
|
|
|||
| // Field (10) 'timestamp' (optional for backwards compatibility) | |||
| if configOnly { | |||
| // TODO(corver): This is a bug, config_hash should use the same check as definitino hash below. | |||
There was a problem hiding this comment.
This is not a bug. It is more like a devX improvement
xenowits
commented
Feb 28, 2024
| @@ -5,7 +5,6 @@ package cluster | |||
| import "testing" | |||
|
|
|||
| const ( | |||
| // TODO: bump version to 1.8 when ready. | |||
There was a problem hiding this comment.
No need for this todo. We always bump cluster version when we release a new one
xenowits
added
the
merge when ready
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
- Coverage 53.68% 53.65% -0.03%
==========================================
Files 200 200
Lines 28232 28231 -1
==========================================
- Hits 15157 15148 -9
- Misses 11202 11213 +11
+ Partials 1873 1870 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove TODOs from the
clusterpackage.category: misc
ticket: none