Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fixing builder registration timestamp #2892

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Feb 21, 2024

Cherrypick of #2810


Use the current timestamp for builder registration messages when using --split-existing-keys mode.

See the issue for the full context.

category: bug
ticket: #2770

Use the current timestamp for builder registration messages when using `--split-existing-keys` mode.

See [the issue](#2770) for the full context.

category: bug
ticket: #2770
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Feb 21, 2024
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gsora gsora changed the title cmd: fixing builder registration timestamp (#2810) cmd: fixing builder registration timestamp Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (31540d4) 53.24% compared to head (8e6a305) 53.40%.

Files Patch % Lines
cmd/createcluster.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           main-v0.19    #2892      +/-   ##
==============================================
+ Coverage       53.24%   53.40%   +0.15%     
==============================================
  Files             200      200              
  Lines           27762    27767       +5     
==============================================
+ Hits            14783    14829      +46     
+ Misses          11146    11108      -38     
+ Partials         1833     1830       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 21, 2024
@obol-bulldozer obol-bulldozer bot merged commit 3c5fdad into main-v0.19 Feb 21, 2024
15 of 16 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/cherrypick_#2810 branch February 21, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants