-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: create dkg cli to support partial deposits #2887
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2887 +/- ##
==========================================
+ Coverage 53.57% 53.66% +0.09%
==========================================
Files 200 200
Lines 28122 28131 +9
==========================================
+ Hits 15065 15096 +31
+ Misses 11190 11173 -17
+ Partials 1867 1862 -5 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
|
||
// WriteDepositDataFile writes deposit-data-*eth.json file for the provided depositDatas. | ||
// The amount will be reflected in the filename in ETH. | ||
// All depositDatas amounts shall have equal values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All depositDatas amounts shall have equal values.
I think it should say All depositDatas amounts should sum up to 32 ETH.
, right? It is not mandatory to have equal values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this case. This function writes the single deposit file for a node. In case of partial deposits this function is called multiple times per each partial amount x each node. The input slice here is the input for the single file. All amounts shall be equal.
Added
--deposit-amounts
flag tocreate dkg
command. DKG procedure itself does not respect the partial amounts yet.This PR only introduces the flag, validation with a bug fix, plus refactoring of writing deposit datas to avoid code duplication.
category: feature
ticket: #2888