Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: revert wire recaster component changes #2877

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Feb 13, 2024

Reverts #2752 as it was not working as expected and was blocking registrations health checks changes.

category: misc
ticket: #2669

@dB2510 dB2510 requested a review from pinebit February 13, 2024 09:03
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (f28b00c) 53.51% compared to head (4d60439) 53.52%.

Files Patch % Lines
app/app.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2877      +/-   ##
==========================================
+ Coverage   53.51%   53.52%   +0.01%     
==========================================
  Files         200      200              
  Lines       28125    28122       -3     
==========================================
+ Hits        15051    15053       +2     
+ Misses      11208    11201       -7     
- Partials     1866     1868       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 13, 2024
@obol-bulldozer obol-bulldozer bot merged commit 3237887 into main Feb 13, 2024
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the revert-2752-dhruv/regtrack branch February 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants