p2p: fixed flakey TestWithSendTimeout #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xenowits
approved these changes
Jan 26, 2024
| p2p.RegisterHandler("test", server, protocolID, func() proto.Message { return new(pbv1.Duty) }, | ||
| func(ctx context.Context, peerID peer.ID, req proto.Message) (proto.Message, bool, error) { | ||
| // The delay must be much greater than the send timeout to trigger the deadline error. |
There was a problem hiding this comment.
See github.com/libp2p/go-yamux/v4@v4.0.1/stream.go for details.
It creates a timer in "future" and then select takes either message or a timer signal. If the test runs fast (the reason for being flakey) select chooses the message and not the timer event in the first pass. Then it closes the stream. That's how I understood the problem..
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
=======================================
Coverage 53.21% 53.22%
=======================================
Files 200 200
Lines 27705 27705
=======================================
+ Hits 14744 14745 +1
Misses 11130 11130
+ Partials 1831 1830 -1 ☔ View full report in Codecov by Sentry. |
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed flakey
TestWithSendTimeout.category: bug
ticket: none