cmd: --deposit-amounts flag #2820
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2820 +/- ##
==========================================
- Coverage 53.27% 53.23% -0.05%
==========================================
Files 199 200 +1
Lines 27700 27738 +38
==========================================
+ Hits 14758 14767 +9
- Misses 11111 11140 +29
Partials 1831 1831 ☔ View full report in Codecov by Sentry. |
|
Thank you @xenowits for the review, addressed your feedback. |
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
cmd/dkg.go
Outdated
| @@ -44,6 +44,7 @@ this command at the same time.`, | |||
| bindLogFlags(cmd.Flags(), &config.Log) | |||
| bindPublishFlags(cmd.Flags(), &config) | |||
| bindShutdownDelayFlag(cmd.Flags(), &config.ShutdownDelay) | |||
| bindPartialDepositsFlag(cmd.Flags(), &config.DepositAmounts) | |||
There was a problem hiding this comment.
why are we introducing this flag in dkg command? In dkg we have cluster-definition.json file at the start and according to the design doc deposit amounts will be there in cluster definition. We can read the deposit amounts field from cluster definition and verify the values from there.
There was a problem hiding this comment.
This was also suggested by the design doc, but probably you are right. Need @xenowits to confirm if this was intentional or not.
There was a problem hiding this comment.
Resolved. Removed option from DKG. Amounts are specified in integer ETHs.
|
pinebit
added
the
merge when ready
Added
--deposit-amountsflag to cmd interface forcreate clusteranddkgcommands in according with the spec.category: feature
ticket: none