cmd/relay: bind debug and monitoring address separately #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same principle as #2808. Refactor the binding functions to be usable across multiple commands.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
+ Coverage 53.18% 53.29% +0.10%
==========================================
Files 199 200 +1
Lines 27705 27705
==========================================
+ Hits 14735 14765 +30
+ Misses 11138 11111 -27
+ Partials 1832 1829 -3 ☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Jan 24, 2024
xenowits
reviewed
Jan 24, 2024
xenowits
approved these changes
Jan 24, 2024
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
|
pinebit
approved these changes
Jan 24, 2024
gsora
added
the
merge when ready
gsora
added a commit
that referenced
this pull request
Jan 24, 2024
Same principle as #2808. Refactor the binding functions to be usable across multiple commands. category: refactor ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same principle as #2808.
Refactor the binding functions to be usable across multiple commands.
category: refactor
ticket: none