Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: revert Herumi to v1.32.1 #2790

Merged
merged 1 commit into from
Jan 16, 2024
Merged

*: revert Herumi to v1.32.1 #2790

merged 1 commit into from
Jan 16, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jan 16, 2024

Cgo dependency linking fails, reverting to a known working version of Herumi.

Upstream ticket: herumi/bls-eth-go-binary#56


Revert "build(deps): Bump github.com/herumi/bls-eth-go-binary from 1.32.1 to 1.33.0 (#2773)"

This reverts commit 42b1118da35c2229f7t d62b30b0a27ed21494250d.

category: fixbuild
ticket: none

Cgo dependency linking fails, reverting to a known working version of
Herumi.

Upstream ticket: herumi/bls-eth-go-binary#56

Revert "build(deps): Bump github.com/herumi/bls-eth-go-binary from 1.32.1 to 1.33.0 (#2773)"

This reverts commit 42b1118da35c2229f7t d62b30b0a27ed21494250d.
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (61b0df4) 0.00% compared to head (94bd6c1) 53.24%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2790       +/-   ##
=========================================
+ Coverage      0   53.24%   +53.24%     
=========================================
  Files         0      199      +199     
  Lines         0    27603    +27603     
=========================================
+ Hits          0    14697    +14697     
- Misses        0    11086    +11086     
- Partials      0     1820     +1820     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 16, 2024
@obol-bulldozer obol-bulldozer bot merged commit dcaaa2b into main Jan 16, 2024
14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/herumi-v1.32.1 branch January 16, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants