Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing registrations as a health check #2760

Closed
2 tasks
boulder225 opened this issue Dec 20, 2023 · 2 comments
Closed
2 tasks

Add failing registrations as a health check #2760

boulder225 opened this issue Dec 20, 2023 · 2 comments
Assignees
Labels
failed proposals protocol Protocol Team tickets

Comments

@boulder225
Copy link

boulder225 commented Dec 20, 2023

🎯 Problem to be solved

Currently, users experiencing high validator registration failures don't have a way to monitor these.

The health checks in charon is a good way to report such problems to our users.

🛠️ Proposed solution

  • Add a new health check high_registration_failure_rate to the app/check package
  • Trigger a warning severity level if >= 70% of registrations fail in an epoch

Tests

Simulate high registration failure rate and check if the health check reports properly in local simnets.

In happy case, you should expect:
Screenshot 2024-02-06 at 21 22 00

In case of high failure rate, expect this instead (high_registration_failure_rate : warning)
Screenshot 2024-02-06 at 21 22 20

@github-actions github-actions bot added the protocol Protocol Team tickets label Dec 20, 2023
@dB2510
Copy link
Contributor

dB2510 commented Jan 31, 2024

Hey team! Please add your planning poker estimate with Zenhub @dB2510 @gsora @pinebit @xenowits

@xenowits xenowits changed the title Add failing registrations as a health check to Charon Add failing registrations as a health check Feb 6, 2024
obol-bulldozer bot pushed a commit that referenced this issue Feb 12, 2024
Added `high_registration_failure_rate` to `app/check` package.

category: feature
ticket: #2760
@pinebit
Copy link
Contributor

pinebit commented Feb 13, 2024

Done.

@pinebit pinebit closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed proposals protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

3 participants