Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vmock to submit selections at the start of epoch for current and next epoch #2400

Closed
3 tasks
dB2510 opened this issue Jul 5, 2023 · 1 comment
Closed
3 tasks

Update vmock to submit selections at the start of epoch for current and next epoch #2400

dB2510 opened this issue Jul 5, 2023 · 1 comment
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Jul 5, 2023 •
edited
Loading

🎯 Problem to be solved

Currently we submit beacon committee selections and sync committee selections at the start of a slot but we want to test our assumptions around submitting beacon committee selections and sync committee selections at the start of an epoch for current and next epoch. This is related to the update that we are proposing in beacon API specs: ethereum/beacon-APIs#334

🛠️ Proposed solution

Update validatormock to submit beacon committee selections and sync committee selections at the start of an epoch for current and next epoch here and here similar what we have when we prepare sync committee message at the start of an epoch here.
Test this change in core team cluster.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Jul 5, 2023
@xenowits xenowits self-assigned this Jul 6, 2023
@dB2510 dB2510 changed the title Update vmock to submit selections at the start of epoch Update vmock to submit selections at the start of epoch for current and next epoch Jul 11, 2023
This was referenced Jul 13, 2023
Closed
Closed
@boulder225 boulder225 assigned corverroos and unassigned xenowits Aug 16, 2023
@dB2510 dB2510 self-assigned this Sep 25, 2023
@dB2510 dB2510 mentioned this issue Sep 28, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Oct 10, 2023
@corverroos
testutil/validatormock: refactor vmock (#2545)
871bd33 
Refactor validatormock to support lookahead for relevant duties like `DutyPrepareAggregator` and `DutySyncContribution`.

category: refactor
ticket: #2400
@dB2510
Copy link
Contributor Author

dB2510 commented Oct 11, 2023

closed by #2545

@dB2510 dB2510 closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@corverroos @dB2510 @xenowits