Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: add bg_ version of split_union_polygon() and split_partitioned_union_polygon() #757

Open
36 of 43 tasks
jipclaassens opened this issue Jul 8, 2024 · 3 comments
Open
36 of 43 tasks

Request: add bg_ version of split_union_polygon() and split_partitioned_union_polygon() #757

jipclaassens opened this issue Jul 8, 2024 · 3 comments
Assignees
@MaartenHilferink
Labels
calculations Producing primary data, functions
Milestone
v15.5

Comments

@jipclaassens
Copy link
Member

jipclaassens commented Jul 8, 2024 •
edited by MaartenHilferink
Loading

Relevant operators to be implemented would be:

Also, make use of cgal.org,

  • cgal_polygon, cgal_union_polygon, cgal_split_polygon, cgal_split_union_polygon
  • cgal_union/join, cgal_intersect, cgal_xor, cgal_difference
  • cgal_overlay_polygon
  • cgal_polygon_connectivity
  • cgal_buffer_multi_polygon
  • cgal_simplify_multi_polygon
  • cgal_buffer_multi_point
  • cgal_buffer_point
  • cgal_buffer_linestring
  • cgal_simplify_linestring
  • cgal_minkowski_sum

For using boost::geometry, we (should) have:

  • bg_polygon, bg_union_polygon, bg_split_polygon, bg_split_union_polygon
  • bg_union, bg_intersect, bg_xor, bg_difference
  • bg_overlay_polygon
  • bg_polygon_connectivity
  • bg_buffer_multi_polygon
  • bg_simplify_multi_polygon
  • bg_buffer_multi_point
  • bg_buffer_point
  • bg_buffer_linestring
  • bg_simplify_linestring
  • bg_minkowski_sum

or, similarly home brewed versions:

  • box_connectivity
  • polygon_connectivity
  • polygon_intersection and overlay with fault tolerant sweep operation

and, using https://libgeos.org/

  • geos_polygon, geos_union_polygon, geos_split_polygon, geos_split_union_polygon
  • geos_union/join, geos_intersect, geos_xor, geos_difference
  • geos_overlay_polygon
  • geos_polygon_connectivity
  • geos_buffer_multi_polygon
  • geos_simplify_multi_polygon
  • geos_buffer_multi_point
  • geos_buffer_point
  • geos_buffer_linestring
  • geos_simplify_linestring
  • geos_minkowski_sum

Furthermore, for xxx in { bp, bg, cgal, geos }:

  • xxx_overlay_polygon and xxx_polygon_connectivity available with one argument with which a self overlay is performed and only forward pairs (i.e. where second_rel > first_rel ) are produced.
MaartenHilferink added a commit that referenced this issue Jul 18, 2024
@MaartenHilferink
#757 WIP
6fdc7be
MaartenHilferink added a commit that referenced this issue Jul 19, 2024
@MaartenHilferink
#757 supplemental
cff7835
MaartenHilferink added a commit that referenced this issue Jul 20, 2024
@MaartenHilferink
#757
de5e217
MaartenHilferink added a commit that referenced this issue Jul 20, 2024
@MaartenHilferink
#757: bg_union_polygon now works.
fa2cd1a
jipclaassens added a commit that referenced this issue Jul 22, 2024
@jipclaassens
#757 merged in outer polygon checks on intersections
4e8bad0
@eoudejans eoudejans mentioned this issue Jul 22, 2024
Open
@MaartenHilferink MaartenHilferink added this to the v15.5 milestone Jul 22, 2024
@MaartenHilferink
Copy link
Collaborator

See my recent comment of #756

@jipclaassens jipclaassens mentioned this issue Jul 22, 2024
Closed
@jipclaassens jipclaassens reopened this Jul 23, 2024
@jipclaassens
Copy link
Member Author

added [[polygon_connectivity]]

MaartenHilferink added a commit that referenced this issue Jul 29, 2024
@MaartenHilferink
#757: Added binary set operations by CGAL
b441726
jipclaassens added a commit that referenced this issue Jul 30, 2024
@jipclaassens
#757 cgal_overlay_polygon additional fixes
dfde88c
MaartenHilferink pushed a commit that referenced this issue Jul 30, 2024
@jipclaassens @MaartenHilferink
#757 cgal_overlay_polygon additional fixes
aafec05
MaartenHilferink added a commit that referenced this issue Jul 31, 2024
@MaartenHilferink
#757: cgal_overlay_polygon fixed by porting Polygon_repair::repair fr…
40b7673 
…om CGAL 6.0 and mimicing CGAL::Multi_polygon_2<K, C> as std::vector<CGAL::Polygon<K, C>>
MaartenHilferink added a commit that referenced this issue Aug 1, 2024
@MaartenHilferink
#757 related code reorganization
dfa323b
MaartenHilferink added a commit that referenced this issue Aug 1, 2024
@MaartenHilferink
#757: added function box_connectivity
28ae27d
MaartenHilferink added a commit that referenced this issue Aug 2, 2024
@MaartenHilferink
#757 box_connectivity, supplemental
116268d
jipclaassens added a commit that referenced this issue Aug 2, 2024
@jipclaassens
#757 diagnostic progess messages during polygon operations
812efe7
MaartenHilferink pushed a commit that referenced this issue Aug 2, 2024
@jipclaassens @MaartenHilferink
#757 diagnostic progess messages during polygon operations
015ac62
MaartenHilferink added a commit that referenced this issue Aug 2, 2024
@MaartenHilferink
#757 box_connectivity, supplemental;
7734b19
MaartenHilferink added a commit that referenced this issue Aug 2, 2024
@MaartenHilferink
#757 box_connectivity now also connects on non-interior IsTouching
bceda6c
@jipclaassens
Copy link
Member Author

jipclaassens commented Aug 2, 2024 •
edited
Loading

Test nieuwbouwpanden (463,000 stuks)

  • bp_spit_union_polygon 1:23 min
  • bp_spit_union_polygon met box_connectivity 1.18 min

Test alle bag panden met alle statussen geinflate (22.5 miljoen), ontkoppeld via fss

MaartenHilferink added a commit that referenced this issue Aug 5, 2024
@MaartenHilferink
#757 geos_overlay_polygon added, WIP
89144a5
MaartenHilferink added a commit that referenced this issue Aug 6, 2024
@MaartenHilferink
#757 geos_overlay_polygon added
9ebc0bb
MaartenHilferink added a commit that referenced this issue Aug 6, 2024
@MaartenHilferink
#757 geos_overlay_polygon: supplemental.
57bc8ab
MaartenHilferink added a commit that referenced this issue Aug 6, 2024
@MaartenHilferink
#757: geos_split_union_polygon, cgal_split_union_polygon
8d379a5
MaartenHilferink added a commit that referenced this issue Aug 6, 2024
@MaartenHilferink
#757 supplemental
6e58410
MaartenHilferink added a commit that referenced this issue Aug 7, 2024
@MaartenHilferink
#757 supplemental.
c1c0c04
MaartenHilferink added a commit that referenced this issue Aug 7, 2024
@MaartenHilferink
#757 supplemental
86f082c
MaartenHilferink added a commit that referenced this issue Aug 8, 2024
@MaartenHilferink
#757 added: geos_buffer_multi_polygon
de83554
MaartenHilferink added a commit that referenced this issue Aug 8, 2024
@MaartenHilferink
#757: added geos_simplify_multi_polygon
c55d74e
MaartenHilferink added a commit that referenced this issue Sep 11, 2024
@MaartenHilferink
#757 xxxx_buffer_point and xxxx_buffer_multi_point
8870316
MaartenHilferink added a commit that referenced this issue Sep 12, 2024
@MaartenHilferink
#757 compiling geos_buffer_multi_point
f899935
MaartenHilferink added a commit that referenced this issue Sep 12, 2024
@MaartenHilferink
#757 cgal_buffer_point, cgal_buffer_multi_point
5aa2cbb
MaartenHilferink added a commit that referenced this issue Sep 12, 2024
@MaartenHilferink
#757 supplemental
47d627a
MaartenHilferink added a commit that referenced this issue Sep 13, 2024
@MaartenHilferink
#757 cgal_buffer_linestring, cgal_simplify_linestring
937ad96
MaartenHilferink added a commit that referenced this issue Sep 14, 2024
@MaartenHilferink
#757 geos binary operator fixes
217f109
@jipclaassens jipclaassens added the calculations Producing primary data, functions label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaartenHilferink MaartenHilferink

Labels
calculations Producing primary data, functions
Projects
None yet
Milestone
v15.5
Development

No branches or pull requests
2 participants
@MaartenHilferink @jipclaassens