Feat add monitoring to chart #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
bendehaan
reviewed
Oct 2, 2023
| @@ -195,7 +178,7 @@ wrongsecrets: | |||
| # -- Optional environment variables to set for each Wrongsecrets instance (see: https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/) | |||
| env: | |||
| - name: K8S_ENV | |||
| value: k8s | |||
| value: gcp | |||
| @@ -94,7 +94,7 @@ balancer: | |||
| REACT_APP_S3_BUCKET_URL: "s3://funstuff" #the s3 bucket you use for the aws challenges, don't forget to make it accessible! | |||
| REACT_APP_GCP_BUCKET_URL: "gs://funstuff" #the gcp bucket you use for the gcp challenges, don't forget to make it accessible! | |||
| REACT_APP_AZ_BLOB_URL: "az://funstuff" #the azure blob storage you use for the azure challenges, don't forget to make it accessible! | |||
| K8S_ENV: "k8s" #or 'aws', 'azure', or 'gcp' | |||
| K8S_ENV: "gcp" #or 'aws', 'azure', or 'gcp' | |||
There was a problem hiding this comment.
Is this change intended?
| @@ -170,7 +153,7 @@ wrongsecrets: | |||
| # -- Specify a custom Wrongsecrets config.yaml. See the Wrongsecrets Docs for any needed ENVs: https://github.com/OWASP/wrongsecrets | |||
| # @default -- See values.yaml for full details | |||
| config: | | |||
| K8S_ENV: k8s | |||
| K8S_ENV: gcp | |||
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
commjoen
reviewed
Oct 9, 2023
| const { get, extractTeamName } = require('./config'); | ||
| const { logger } = require('./logger'); | ||
|
|
||
| const app = express(); | ||
|
|
||
| if (get('metrics.enabled')) { |
There was a problem hiding this comment.
why delete the metrics endpoint and config from the balancer?
bendehaan
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Prometheus and grafana to the chart
What kind of changes does this PR include?
Checklist: