Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in demo threat descriptions #951

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ThreatDragonModels/demo-threat-model.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
{
"status": "Open",
"severity": "Medium",
"description": "An attacker could obtain the DB credentials ans use them to make unauthorised queries.",
"description": "An attacker could obtain the DB credentials and use them to make unauthorised queries.",
"title": "Credential theft",
"type": "Information disclosure",
"mitigation": "Use a firewall to restrict access to the DB to only the Background Worker IP address."
Expand Down Expand Up @@ -133,7 +133,7 @@
"severity": "High",
"title": "Credentials should be encrypted",
"type": "Information disclosure",
"description": "The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.",
"description": "The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.",
"mitigation": "The Message Queue credentials should be encrypted."
}
],
Expand Down
4 changes: 2 additions & 2 deletions ThreatDragonModels/v2-threat-model.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
{
"status": "Open",
"severity": "Medium",
"description": "An attacker could obtain the DB credentials ans use them to make unauthorised queries.",
"description": "An attacker could obtain the DB credentials and use them to make unauthorised queries.",
"title": "Credential theft",
"type": "Information disclosure",
"mitigation": "Use a firewall to restrict access to the DB to only the Background Worker IP address.",
Expand Down Expand Up @@ -173,7 +173,7 @@
"severity": "High",
"title": "Credentials should be encrypted",
"type": "Information disclosure",
"description": "The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.",
"description": "The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.",
"mitigation": "The Message Queue credentials should be encrypted.",
"modelType": "STRIDE",
"id": "aaea0238-2984-4b25-8268-3798e63bed34"
Expand Down
4 changes: 2 additions & 2 deletions td.vue/src/service/demo/demo-threat-model.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default {
{
'status': 'Open',
'severity': 'Medium',
'description': 'An attacker could obtain the DB credentials ans use them to make unauthorised queries.',
'description': 'An attacker could obtain the DB credentials and use them to make unauthorised queries.',
'title': 'Credential theft',
'type': 'Information disclosure',
'mitigation': 'Use a firewall to restrict access to the DB to only the Background Worker IP address.'
Expand Down Expand Up @@ -134,7 +134,7 @@ export default {
'severity': 'High',
'title': 'Credentials should be encrypted',
'type': 'Information disclosure',
'description': 'The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.',
'description': 'The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.',
'mitigation': 'The Message Queue credentials should be encrypted.'
}
],
Expand Down
4 changes: 2 additions & 2 deletions td.vue/src/service/demo/v2-threat-model.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export default {
{
'status': 'Open',
'severity': 'Medium',
'description': 'An attacker could obtain the DB credentials ans use them to make unauthorised queries.',
'description': 'An attacker could obtain the DB credentials and use them to make unauthorised queries.',
'title': 'Credential theft',
'type': 'Information disclosure',
'mitigation': 'Use a firewall to restrict access to the DB to only the Background Worker IP address.',
Expand Down Expand Up @@ -173,7 +173,7 @@ export default {
'severity': 'High',
'title': 'Credentials should be encrypted',
'type': 'Information disclosure',
'description': 'The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.',
'description': 'The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.',
'mitigation': 'The Message Queue credentials should be encrypted.',
'modelType': 'STRIDE',
'id': 'aaea0238-2984-4b25-8268-3798e63bed34'
Expand Down
4 changes: 2 additions & 2 deletions td.vue/tests/e2e/fixtures/v1-model.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
{
"status": "Open",
"severity": "Medium",
"description": "An attacker could obtain the DB credentials ans use them to make unauthorised queries.",
"description": "An attacker could obtain the DB credentials and use them to make unauthorised queries.",
"title": "Credential theft",
"type": "Information disclosure",
"mitigation": "Use a firewall to restrict access to the DB to only the Background Worker IP address."
Expand Down Expand Up @@ -133,7 +133,7 @@
"severity": "High",
"title": "Credentials should be encrypted",
"type": "Information disclosure",
"description": "The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.",
"description": "The Web Application Config stores credentials used by the Web App to access the message queue. These could be stolen by an attacker and used to read confidential data or place poison message on the queue.",
"mitigation": "The Message Queue credentials should be encrypted."
}
],
Expand Down