Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule plugins simple2 #231

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Thorsten-Sick
Copy link

As discussed in issue #19 A PR for an additional plugin system to cover rule plugins. As an example it contains a semi complex sql injection plugin.

super().__init__()
self.plugin_path = __file__

def connected_elements(self, element):
Copy link
Collaborator

@colesmj colesmj Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a function of an Element rather than in the rule definition? Seems it could be reused for other things, and taking a couple of extra parameters perhaps to be generically useful.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be better. I want to make changes by this feature in the core code as minimal as possible. Maybe create a separate PR for the Element upgrade ? Which parameters do you propose ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants