Exposed conditiion to report template and moved html encoding the TM.… #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozmore
force-pushed
the
expose_condition
branch
from
9ff8245 to
85c1f23
Compare
nineinchnick
approved these changes
Apr 2, 2021
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
izar
approved these changes
Apr 7, 2021
nozmore
pushed a commit
that referenced
this pull request
Apr 13, 2021
nozmore
pushed a commit
that referenced
this pull request
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…report method
Initially I just wanted to expose Threat conditions to the report template but because HTML encoding was done when the threats were read in that would have broken eval logic. To address this I moved html encoding to the TM.report method and encode threat data from within the list of threats and findings.
With this change json output is json encoded but not html encoded and output to report used to generate the markdown file then html via pandoc is html encoded.