Docker-Multi Stage Build #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
frontend
docker
Dishant1804
commented
Feb 7, 2025
|
@Dishant1804 |
|
@Dishant1804 any update on this, are you still looking into it? |
|
@yashgoyal0110 let @arkid15r reply with the correct approach with the ci/cd failure that is happening, then i am more than happy to share the metrics, also i was busy for couple of days as we have personal lives too. I would kindly request you to please have a bit patience :) |
|
@arkid15r made the changes, i let the poetry be installed in the runtime stage of test file inorder to run pytest :) |
arkid15r
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Should we update docker compose files too?
Nest/docker-compose-staging.yaml
Line 7 in c6ade0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #734
Modified Dockerfiles that previously lacked support for multi-stage builds, now the necessary files support mullti-stage builds