Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audience attribute with test case #714

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

Dishant1804
Copy link
Collaborator

Resolves #687

Added audience attribute to the project.json file, also added positive and negative test cases to test the schema file.

@Dishant1804
Copy link
Collaborator Author

@arkid15r I've made the necessary changes as expected, please review it and let me know if any changes are required :)

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good and the only thing I suggest to improve is to follow the properties alphabetical ordering everywhere.

@github-actions github-actions bot added the schema label Feb 2, 2025
@Dishant1804
Copy link
Collaborator Author

Dishant1804 commented Feb 3, 2025

This looks really good and the only thing I suggest to improve is to follow the properties alphabetical ordering everywhere.

@arkid15r Thank you for suggesting, i've made the properties in alphabetically order, please review and suggest if any changes are required :)

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Feb 3, 2025
Merged via the queue into OWASP:main with commit 6b47d04 Feb 3, 2025
17 checks passed
@Dishant1804 Dishant1804 deleted the audience_schema branch February 3, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add audience to project schema
2 participants