Fetch /gsoc command data from Algolia instead of DB #712
+28
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arkid15r I've made necessary changes. Please let me know if any changes are required :) |
arkid15r
requested changes
Feb 2, 2025
There was a problem hiding this comment.
You should use existing owasp/api/search/project logic instead.
There was a problem hiding this comment.
So, the get_gsoc_projects function needs to be placed in owasp/api/search/project, correct? Let me know if this seems like the right direction. Correct me if i am not thinking in the direction as you are
arkid15r
reviewed
Feb 2, 2025
| from apps.owasp.models.project import Project | ||
|
|
||
| query = f"gsoc{year}" | ||
| searchable_attributes = ["idx_custom_tags"] |
There was a problem hiding this comment.
I think we should extend it to idx_tags too.
There was a problem hiding this comment.
sure i'll extend it to idx_tags and idx_topics as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #686
Made a separate file for gsoc search api that fetches the data from algolia, also the searchable attribute is set to
idx_custom_tagsso that we only get the tag list, which was expected in the issue.