Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed incositency while changing from light to dark vice versa #669

Closed
wants to merge 5 commits into from

Conversation

abhayymishraa
Copy link
Collaborator

Resolves #662

Add the PR description here.

Tasks

  • fixed incosistency when switching from dark to light or light to dark

Preview

Screencast.from.30-01-25.11.45.08.PM.IST.webm

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajgupta36 could you verify the bug fix?
Thank you

@Naveen-Pal
Copy link
Collaborator

Naveen-Pal commented Jan 30, 2025

looks sync, but the star icon (on top right) seems to have slight delay.

@abhayymishraa
Copy link
Collaborator Author

@Naveen-Pal i will fix it !! i somehow missed that

@Naveen-Pal
Copy link
Collaborator

Naveen-Pal commented Jan 30, 2025

image
Also pagination component look like to have a slight delay.

@abhayymishraa
Copy link
Collaborator Author

abhayymishraa commented Jan 30, 2025

@Naveen-Pal It would be like this. Is it good. could you review it ?

@Naveen-Pal
Copy link
Collaborator

Looks good

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhayymishraa this PR contains 0 files changed.

@abhayymishraa
Copy link
Collaborator Author

@abhayymishraa this PR contains 0 files changed.

hey @arkid15r because that already got merged by you from my different account remember :)

@abhayymishraa
Copy link
Collaborator Author

hey @arkid15r this is it can you complete this request so that it can be mentioned in the tasks
I have added the pre-commit to check test files.
i have fixed the inconsistency.

@arkid15r
Copy link
Collaborator

arkid15r commented Feb 3, 2025

hey @arkid15r this is it can you complete this request so that it can be mentioned in the tasks I have added the pre-commit to check test files. i have fixed the inconsistency.

I believe it's tracked here -- #662

@arkid15r arkid15r closed this Feb 3, 2025
@abhayymishraa abhayymishraa deleted the fix/incosistency branch February 3, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between transition in light and dark mode
3 participants