Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharelink #3329

Closed
wants to merge 0 commits into from
Closed

Sharelink #3329

wants to merge 0 commits into from

Conversation

iitzIrFan
Copy link

@iitzIrFan iitzIrFan commented Feb 4, 2025

Issue :- #3243

  • The URL will automatically adapt to whatever domain you're using
  • Works with local development, ngrok, and production
  • No need to update code when ngrok URL changes
  • More maintainable solution

@DonnieBLT DonnieBLT enabled auto-merge (squash) February 4, 2025 16:38
@CodeWithBishal
Copy link
Contributor

Hey @iitzIrFan,
Some of the checks are failing

  • Please run pre-commit(pre-commit run --all-files) and push those changes.
  • Please mention which issue is getting closed by this PR?

@iitzIrFan
Copy link
Author

@CodeWithBishal
Issue is updated !

@CodeWithBishal
Copy link
Contributor

@iitzIrFan Pre-commit is still failing, did you run pre-commit run --all-files on your fork?
you have to open your fork -> and run pre-commit run --all-files in your terminal then commit the changes here
for the first time you may need to install pre-commit pre-commit install --hook-type pre-push

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the pre-commit

auto-merge was automatically disabled February 13, 2025 18:46

Head branch was pushed to by a user without write access

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the changes to the files not related to this sharelink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants