-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added img & desc. for share link #3296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just change the header for the one file
website/templates/issue.html
Outdated
@@ -26,14 +33,27 @@ | |||
<link rel="canonical" href="https://{% env 'FQDN' %}/issue/{{ object.id }}"> | |||
<meta property="og:url" | |||
content="https://{% env 'FQDN' %}/issue/{{ object.id }}" /> | |||
<meta property="og:type" content="website" /> | |||
<meta property="og:type" content="article" /> | |||
<meta property="og:site_name" content="{% env 'PROJECT_NAME' %}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please just keep these changes and not the other file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok will update !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT Have updated the changes plz chk and let me know if there are any !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iitzIrFan only the issue.html file should change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT Had updated as per the requirements ! plz chk and let me know !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT I had seen there is an error on deletion of issues so should I update that, also ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT I had seen there is an error on deletion of issues so should I update that, also ?
That would be great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you will have to use the {% block og_title %} block tags to override the base.html template to pass the values through
website/templates/issue.html
Outdated
@@ -26,14 +33,27 @@ | |||
<link rel="canonical" href="https://{% env 'FQDN' %}/issue/{{ object.id }}"> | |||
<meta property="og:url" | |||
content="https://{% env 'FQDN' %}/issue/{{ object.id }}" /> | |||
<meta property="og:type" content="website" /> | |||
<meta property="og:type" content="article" /> | |||
<meta property="og:site_name" content="{% env 'PROJECT_NAME' %}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT I had seen there is an error on deletion of issues so should I update that, also ?
That would be great!
website/templates/issue.html
Outdated
@@ -26,14 +33,27 @@ | |||
<link rel="canonical" href="https://{% env 'FQDN' %}/issue/{{ object.id }}"> | |||
<meta property="og:url" | |||
content="https://{% env 'FQDN' %}/issue/{{ object.id }}" /> | |||
<meta property="og:type" content="website" /> | |||
<meta property="og:type" content="article" /> | |||
<meta property="og:site_name" content="{% env 'PROJECT_NAME' %}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you will have to use the {% block og_title %} block tags to override the base.html template to pass the values through
@@ -406,4 +406,4 @@ <h3>Liked By:</h3> | |||
} | |||
}) | |||
} | |||
</script> | |||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this whitespace change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for this whitespace change
It's just an style suggestion !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better in a separate pull request. This change is for code rated to the image headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT Can you specify this more for better understanding ! Also it's related to whitespace right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just keep this PR related to changes required for the image headers if possible. Only one file needs to change, not 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok as I had changed them previously so I did this change !
<meta property="og:type" content="article" /> | ||
<meta property="og:site_name" content="{% env 'PROJECT_NAME' %}" /> | ||
|
||
{% if object.screenshot %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’d also want to check for the related screenshots as that is the new way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code cleanup can be a separate pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes required
@DonnieBLT |
Add social sharing meta tags for issue pages
This enhances social sharing previews when users share issue links on
social media platforms, providing better visibility and context for
shared bug reports.