Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLT Private Project #1737

Closed
wants to merge 66 commits into from
Closed

BLT Private Project #1737

wants to merge 66 commits into from

Conversation

HanilJain
Copy link
Contributor

@HanilJain HanilJain commented Feb 3, 2024

Project Done #1702

Related #1090 #1685

description

BLT private project have Private Issue Page where all the Private Issue are listed and viewership can be managed.
request made by any user and people who have access are listed which can be granted or declined the access.
User could request access for Private Issue with message and the owner will notified by the mail , If access is granted the user will be notified through email and can view the Private Issue.

Feature

  • Request Access for Private Issue
  • Email Notification on Request Request and approval
  • viewership management of Private Issue
  • dedicated page for Private Issue management
  • Well Tested and security management

workflow

Screenshot 2024-02-04 050207

Screnshot

Request Access

Private Issue on User Profile

Private Issue Listed

Viewership Managment

@HanilJain
Copy link
Contributor Author

HanilJain commented Feb 3, 2024

@DonnieBLT Sir , could you please review

@HanilJain
Copy link
Contributor Author

This has both #1691 #1729 with additional feature fixing #1090 #1685.

@DonnieBLT
Copy link
Collaborator

I think this may need an update / conflict check

@DonnieBLT
Copy link
Collaborator

Can you please resolve the conflicts and update the branch?

@HanilJain
Copy link
Contributor Author

@DonnieBLT Done please check.

@HanilJain HanilJain requested a review from arkid15r February 27, 2024 09:17
@HanilJain HanilJain requested a review from DonnieBLT February 28, 2024 11:21
@Sarthak5598
Copy link
Member

Great work @HanilJain , Happy to have someone this skilled as a peer

@HanilJain
Copy link
Contributor Author

Great work @HanilJain , Happy to have someone this skilled as a peer

Thanks @Sarthak5598 , but its nothing like that : )

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see a couple tweaks and concerns

website/models.py Show resolved Hide resolved
website/models.py Show resolved Hide resolved
@@ -0,0 +1,61 @@
{% load custom_tags %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an HTML file, but labeled as.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonnieBLT It mail content which will sent after an access is granted

website/views.py Show resolved Hide resolved
blt/urls.py Outdated
@@ -319,7 +319,7 @@
path("issue/<str:issue_pk>/comment/update/<str:comment_pk>/", website.views.update_comment, name="update_comment"),
# delete_comment
path("issue2/comment/delete/", website.views.delete_comment, name="delete_comment"),
path("issue/<int:slug>/" , IssueView.as_view() , name = "issue_view"),
re_path(r"^issue/(?P<slug>\w+)/$", IssueView.as_view(), name="issue_view"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonnieBLT Made the changes !!
I think this was only required here ?
am I correct ?

website/templates/email/granted_access.txt Show resolved Hide resolved
website/views.py Outdated Show resolved Hide resolved
website/templates/grant_access.html Outdated Show resolved Hide resolved
website/decorator.py Show resolved Hide resolved
website/views.py Show resolved Hide resolved
website/models.py Show resolved Hide resolved
website/models.py Show resolved Hide resolved
@@ -0,0 +1,61 @@
{% load custom_tags %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonnieBLT It mail content which will sent after an access is granted

Copy link
Contributor Author

@HanilJain HanilJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonnieBLT I have realised on the previous suggested changes i have replied to bu forget to submit review, hence not got posted

@HanilJain HanilJain requested a review from DonnieBLT March 7, 2024 18:16
@HanilJain
Copy link
Contributor Author

@DonnieBLT Made all suggested changes 7e2081e

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please split these into smaller PRs

@HanilJain
Copy link
Contributor Author

Can you please split these into smaller PRs

Yup i'll do it

@DonnieBLT
Copy link
Collaborator

can you please split this into smaller PRs?

@DonnieBLT DonnieBLT closed this May 25, 2024
@HanilJain
Copy link
Contributor Author

@DonnieBLT For sure I have planned do it in upcoming few days.

@HanilJain HanilJain deleted the issue-1702 branch June 27, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants