-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLT Private Project #1737
BLT Private Project #1737
Conversation
@DonnieBLT Sir , could you please review |
I think this may need an update / conflict check |
Can you please resolve the conflicts and update the branch? |
@DonnieBLT Done please check. |
website/migrations/0086_rename_requestaccess_requestissueaccess.py
Outdated
Show resolved
Hide resolved
Great work @HanilJain , Happy to have someone this skilled as a peer |
Thanks @Sarthak5598 , but its nothing like that : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see a couple tweaks and concerns
@@ -0,0 +1,61 @@ | |||
{% load custom_tags %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an HTML file, but labeled as.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT It mail content which will sent after an access is granted
blt/urls.py
Outdated
@@ -319,7 +319,7 @@ | |||
path("issue/<str:issue_pk>/comment/update/<str:comment_pk>/", website.views.update_comment, name="update_comment"), | |||
# delete_comment | |||
path("issue2/comment/delete/", website.views.delete_comment, name="delete_comment"), | |||
path("issue/<int:slug>/" , IssueView.as_view() , name = "issue_view"), | |||
re_path(r"^issue/(?P<slug>\w+)/$", IssueView.as_view(), name="issue_view"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT Made the changes !!
I think this was only required here ?
am I correct ?
@@ -0,0 +1,61 @@ | |||
{% load custom_tags %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT It mail content which will sent after an access is granted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonnieBLT I have realised on the previous suggested changes i have replied to bu forget to submit review, hence not got posted
@DonnieBLT Made all suggested changes 7e2081e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please split these into smaller PRs
Yup i'll do it |
can you please split this into smaller PRs? |
@DonnieBLT For sure I have planned do it in upcoming few days. |
Project Done #1702
Related #1090 #1685
description
BLT private project have Private Issue Page where all the Private Issue are listed and viewership can be managed.
request made by any user and people who have access are listed which can be granted or declined the access.
User could request access for Private Issue with message and the owner will notified by the mail , If access is granted the user will be notified through email and can view the Private Issue.
Feature
workflow
Screnshot