Adjust FindSDL2 to hopefully be able to find the framework on Mac (take two) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2015
|
Aside from some minor formatting tweaks (I hate spaces vs tabs and wish editors would just handle it automatically better than they do), this looks great, thanks! I assume you've tried it locally and it works with SDL? Doesn't look like Travis has SDL installed. |
rpavlik
added a commit
that referenced
this pull request
Oct 12, 2015
Adjust FindSDL2 to hopefully be able to find the framework on Mac (take two)
|
Yep, this works with SDL. I could add SDL to the Travis configs if you want. |
|
cool. Feel free to, the more stuff builds on CI, the better it serves as a check to development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the aforementioned changes in #232 (comment) and works for me.