imaging merge (in-process memory image message and jni bridge code) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This must be enabled in CMake (default off).
…s to create the image copy.
…will determine the depth/channels.
JeroMiya
changed the title
| @@ -23,8 +23,11 @@ if(BUILD_WITH_TRACING) | |||
| endif() | |||
| endif() | |||
|
|
|||
| option(OSVR_COMMON_IN_PROCESS_IMAGING OFF) | |||
There was a problem hiding this comment.
Think this is not quite the right syntax for option() - think there's usually a description in there.
There was a problem hiding this comment.
also probably want a mark_as_advanced
JeroMiya
added a commit
that referenced
this pull request
Oct 13, 2015
imaging merge (in-process memory image message and jni bridge code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional in-process memory image message implementation (turn on with CMAKE option), and temporarily adding jni bridge hack to pluginKit.