-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masking Changes and DataFrame Read and Write Capabilities #148
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 87.23% 87.54% +0.30%
==========================================
Files 14 13 -1
Lines 525 578 +53
==========================================
+ Hits 458 506 +48
- Misses 67 72 +5 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@leewujung, Here are some slight changes made corresponding to errors that I noticed when running echoregion functions in hake labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctuguinay : I have only a comment and a question for changes in this PR.
An offshoot when I was looking at the tests: seems like there is a missing assert
condition in the last line of test_mask_empty_no_overlap
?
I think this PR can be merged once we have the above addressed.
While reviewing it I created #151 that should be addressed in a separate PR.
Thanks!
Just added this assert. |
Recent Changes:
|
@leewujung This is ready to be reviewed again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctuguinay : Everything looks good and I only had very minor comments. Feel free to merge afterwards!
Co-authored-by: Wu-Jung Lee <leewujung@gmail.com>
For lines masking: Clean up how
bottom_interpolated
is constructed. Past version had unused variables.For regions2d masking: Made use of numbers instead of names in regionmask regions initialization so to work directly with the dimension region instead of having to switch coordinate names with dimension regions.
Also, solved problem where echoregions version cannot be imported in the top level
__init__.py
file of the package.