Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI: fix for Python3.13 #4653

Merged
merged 1 commit into from
Nov 5, 2024
Merged

GUI: fix for Python3.13 #4653

merged 1 commit into from
Nov 5, 2024
+31 −21

Conversation

petrasovaa
Copy link
Contributor

Fixes #4651. vars() acts like locals() and there have been some changes:
https://docs.python.org/3/whatsnew/3.13.html#whatsnew313-locals-semantics

@petrasovaa petrasovaa added the bug Something isn't working label Nov 5, 2024
@petrasovaa petrasovaa added this to the 8.4.1 milestone Nov 5, 2024
@petrasovaa petrasovaa added the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 5, 2024
@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Nov 5, 2024
echoix
echoix approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New code seems fine, but I don't understand why vars() was needed before

@petrasovaa
Copy link
Contributor Author

New code seems fine, but I don't understand why vars() was needed before

Not sure either

wenzeslaus
wenzeslaus approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea was to create local variables dynamically. Dictionary is a better solution for dynamically managing multiple key-value pairs.

@echoix echoix merged commit f15230d into OSGeo:main Nov 5, 2024
27 checks passed
@a0x8o a0x8o mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
backport to 8.4 PR needs to be backported to release branch 8.4 bug Something isn't working GUI wxGUI related Python Related code is in Python
Projects
None yet
Milestone
8.4.1
Development

Successfully merging this pull request may close these issues.

[Bug] Error when launching GUI on Fedora 41
3 participants
@petrasovaa @wenzeslaus @echoix