Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add expat dependency to macOS runner #4646

Merged
merged 1 commit into from
Nov 4, 2024
Merged

CI: add expat dependency to macOS runner #4646

merged 1 commit into from
Nov 4, 2024

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Nov 4, 2024

No description provided.

@github-actions github-actions bot added the CI Continuous integration label Nov 4, 2024
@nilason nilason mentioned this pull request Nov 4, 2024
Closed
@nilason nilason linked an issue Nov 4, 2024 that may be closed by this pull request
[Bug] macOS builds are failing #4644
Closed
@nilason nilason added this to the 8.5.0 milestone Nov 4, 2024
@nilason nilason added the macOS macOS specific label Nov 4, 2024
@nilason nilason enabled auto-merge (squash) November 4, 2024 21:27
@echoix echoix mentioned this pull request Nov 4, 2024
Open
@nilason nilason merged commit d4bb783 into OSGeo:main Nov 4, 2024
24 checks passed
@neteler
Copy link
Member

neteler commented Nov 4, 2024

To be backported to G8.4, @nilason ?

@echoix
Copy link
Member

echoix commented Nov 4, 2024

Most probably, as the macOS builds should fail too as the conda environment would resolve the same

@nilason
Copy link
Contributor Author

nilason commented Nov 4, 2024

To be backported to G8.4, @nilason ?

Yes.

@nilason nilason added the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 4, 2024
@neteler
Copy link
Member

neteler commented Nov 4, 2024

Mhh, the file versions differ too much and git cherry-picking fails.

@nilason
Copy link
Contributor Author

nilason commented Nov 4, 2024

Mhh, the file versions differ too much and git cherry-picking fails.

I can take look tomorrow.

@nilason nilason deleted the fix-mac branch November 5, 2024 07:32
nilason added a commit that referenced this pull request Nov 5, 2024
@nilason
CI: add expat dependency to macOS runner (#4646)
64fece0
@nilason nilason modified the milestones: 8.5.0, 8.4.1 Nov 5, 2024
@nilason
Copy link
Contributor Author

nilason commented Nov 5, 2024

Backported with 64fece0 (together with 926cf21).

@nilason nilason removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 5, 2024
@a0x8o a0x8o mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
CI Continuous integration macOS macOS specific
Projects
None yet
Milestone
8.4.1
Development

Successfully merging this pull request may close these issues.

[Bug] macOS builds are failing
3 participants
@nilason @neteler @echoix