New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/ogsf: Dereference after null check in gvl2.c #4588

Merged

echoix merged 1 commit into OSGeo:main from ShubhamDesai:issue_71

Oct 30, 2024

Contributor

ShubhamDesai commented Oct 24, 2024 •

edited

Loading

This pull request addresses the issue identified by coverity scan (CID: 1207416)

Added else block where gvl might be null.
Used G_debug with level 2 which is moderate as it is already aware that it is accessing null volume structure through the message
Thought behind using G_debug was to print some additional logs instead of just G_warning. (Open to change to normal G_warning or any other level in G_debug)


          Dereference after null check

bb2d015

github-actions bot added C libraries labels

marisn approved these changes

View reviewed changes

echoix approved these changes

View reviewed changes

echoix merged commit 528763f into OSGeo:main

27 checks passed

github-actions bot added this to the 8.5.0 milestone

a0x8o mentioned this pull request

E722 a0x8o/grass#21

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels