-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add regression test for r.his #4572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raster
Related to raster data processing
Python
Related code is in Python
module
tests
Related to Test Suite
labels
Oct 22, 2024
Failing with
|
echoix
previously approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't analyze to look for what isn't there, but what is there makes sense ;)
Thanks for a new test on a module that didn't have some yet!
petrasovaa
reviewed
Oct 23, 2024
petrasovaa
reviewed
Oct 23, 2024
Apply the suggestion. Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
Apply the suggestion. Co-authored-by: Anna Petrasova <kratochanna@gmail.com>
Black styling Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
petrasovaa
approved these changes
Oct 24, 2024
echoix
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added regression test for r.his.
Motivation and context
There was no testing for r.his.
How has this been tested?
Locally tested with
python <path>/raster/r.his/testsuite/test_r_his.py
Types of changes
functionality to not work as before)
Checklist
pre-defined prefixes