Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.buildvrt: document performance issues with external data #4441

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented Oct 3, 2024

This PR aims at documenting the known performance issues of GRASS VRTs with external, linked data.

Not sure, if or how to mention the r.buildvrt.gdal addon?

Fix: #4345

@ninsbl ninsbl added manual Documentation related issues raster Related to raster data processing HTML Related code is in HTML labels Oct 3, 2024
@ninsbl ninsbl added this to the 8.5.0 milestone Oct 3, 2024
@wenzeslaus
Copy link
Member

Not sure, if or how to mention the r.buildvrt.gdal addon?

Definitively mention it. And also add it to "See also" too with full URL to grass-stable.

@ninsbl
Copy link
Member Author

ninsbl commented Oct 25, 2024

Comments addressed in 223e8e5

@ninsbl ninsbl requested a review from neteler October 25, 2024 07:16
ninsbl and others added 2 commits October 25, 2024 10:15
Co-authored-by: Markus Neteler <markus@neteler.org>
@ninsbl
Copy link
Member Author

ninsbl commented Oct 25, 2024

Thanks for the review @neteler Suggestions are now included. I also condensed the recommendation for GDAL-linked raster maps.

@echoix echoix merged commit f9f01e1 into OSGeo:main Oct 31, 2024
23 checks passed
@a0x8o a0x8o mentioned this pull request Nov 6, 2024
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Nov 11, 2024
* document performance issue

* address code review

* Apply suggestions from code review

Co-authored-by: Markus Neteler <markus@neteler.org>

* consistent recommendation

* remove leftover dot

---------

Co-authored-by: Markus Neteler <markus@neteler.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs HTML Related code is in HTML manual Documentation related issues module raster Related to raster data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] r.buildvrt: significant read performance issues with virtual raster maps
4 participants