Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d.redraw: Rewritten in C #3727

Merged
merged 1 commit into from
May 21, 2024
Merged

d.redraw: Rewritten in C #3727

merged 1 commit into from
May 21, 2024

Conversation

HuidaeCho
Copy link
Member

@HuidaeCho HuidaeCho commented May 21, 2024 •
edited by neteler
Loading

This PR rewrites the d.redraw Python script in C.

This PR replaces #3484. For details, see there.

@github-actions github-actions bot added Python Related code is in Python C Related code is in C HTML Related code is in HTML module docs display labels May 21, 2024
This was referenced May 21, 2024
Closed
Merged
@neteler neteler added this to the 8.4.0 milestone May 21, 2024
@HuidaeCho HuidaeCho self-assigned this May 21, 2024
@HuidaeCho HuidaeCho requested a review from neteler May 21, 2024 20:07
neteler
neteler approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried #3727 and #3500 together. The updated monitor seems to behave as expected (the test case above runs as expected for me).

@HuidaeCho HuidaeCho enabled auto-merge (squash) May 21, 2024 20:37
@HuidaeCho HuidaeCho merged commit 75375c9 into OSGeo:main May 21, 2024
26 checks passed
@HuidaeCho HuidaeCho deleted the new_d_redraw_c_2 branch May 22, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler neteler approved these changes

Assignees

@HuidaeCho HuidaeCho

Labels
C Related code is in C display docs HTML Related code is in HTML module Python Related code is in Python
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HuidaeCho @neteler