WIP: Move "get involved" section from development to contribute landing page #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, I used this PR to solve #116 as well... I just removed the empty md file |
|
Just don't merge #119 |
neteler
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
It looks good to me! https://staging.grass.osgeo.org/contribute/
I like the solution with the font awesome icons.
nbozon
approved these changes
Apr 18, 2020
|
Since there are already 2 approvals, I am merging this one. We can undo or create a different PR if the majority disagrees. |
I'd rather like to make them a little larger, but 6x, 7x and so on, produce tiny icons instead. Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also replaces the images removed in #72 with fa icons as suggested in #114. I've noticed by trial and error that the maximum size for fa icons is 5x, would it be possible to increase the size a lil bit further??