Add support for comments in ERS files #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Nov 15, 2021
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
rouault
reviewed
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for comments in ERS file headers. A comment starts with a
#character and continues to the end of the line. ER Mapper documentation describes comments in this fashion and we've recently encountered files in the wild that contain comments. Since comments may appear at the start of the file, ERS file identification logic is modified to accommodate presence of such comments.The
srtm.erstest case is modified to exercise comment logic and all ERS test cases are still passing.