GDALAutoCreateWarpedVRTEx(): do not set padfSrcNoDataReal/padfDstNoDataReal if already set in passed-in options (fixes mapbox/rasterio#2233) #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taReal if already set in passed-in options (fixes rasterio/rasterio#2233)
sgillies
reviewed
Oct 13, 2021
| for( int i = 0; i < psWO->nBandCount; i++ ) | ||
| if( psWO->padfSrcNoDataReal == nullptr && | ||
| psWO->padfDstNoDataReal == nullptr && | ||
| psWO->nSrcAlphaBand == 0 ) |
There was a problem hiding this comment.
@rouault in rasterio/rasterio#2233 we'd like the arrays to be NULL, have no source alpha band, but then use the source's internal mask band. I haven't had a chance to try this PR yet, but I think my use case will pass that test above, and shouldn't.
There was a problem hiding this comment.
but then use the source's internal mask band
use of the source's internal (non-alpha) mask band is something that has no direct control in the psWO structure. It should trigger automatically in the WarpOperation logic at https://github.com/OSGeo/gdal/blob/master/gdal/alg/gdalwarpoperation.cpp#L2149
github-actions bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
GDALAutoCreateWarpedVRTEx(): do not set padfSrcNoDataReal/padfDstNoDataReal if already set in passed-in options (fixes rasterio/rasterio#2233)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.