createFromCRSCodesWithIntermediates(): improve perf when no match #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createFromCRSCodesWithIntermediates() runs a rather costly self-join. Only run it if the source and target CRS are the source/target of a coordinate operation. This helps for the performance of proj_create_crs_to_crs() when run on projected CRS for example that are extremely unlikely to be the source/target of an operation (except currently the Finish ones). For the EPSG:26915 to EPSG:3857 case of OSGeo/gdal#3470, this helps decreasing the time of proj_create_crs_to_crs() from 18 ms to 10 ms.
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Mar 18, 2021
Helps decreasing the gdalwarp time of OSGeo#3470 from 123 ms to 113 ms. And with OSGeo/PROJ#2583, we go down to 105 ms. Compared to the 80 ms of GDAL 2.4/PROJ 5.2, and the ~ 300ms of GDAL 3.2/PROJ 8
|
Backported to 8.0 per 9393831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createFromCRSCodesWithIntermediates() runs a rather costly self-join.
Only run it if the source and target CRS are the source/target of a
coordinate operation. This helps for the performance of
proj_create_crs_to_crs() when run on projected CRS for example that are
extremely unlikely to be the source/target of an operation (except
currently the Finish ones). For the EPSG:26915 to EPSG:3857 case of
OSGeo/gdal#3470, this helps decreasing the
time of proj_create_crs_to_crs() from 18 ms to 10 ms.