Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameterize #71

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Fix parameterize #71

merged 2 commits into from
Apr 2, 2020

Conversation

johrstrom
Copy link
Contributor

@johrstrom johrstrom commented Apr 1, 2020 •
edited
Loading

Fixes #70. The first commit adds the test case that triggers the bug. just git reset cd5be9578c150f4d8256edcb31cd86fed5e8b6ba --hard && rake test to verify.

https://apidock.com/rails/ActiveSupport/Inflector/parameterize for reference.

@johrstrom
add test case for results_valid? that triggers exception
cd5be95
@johrstrom
fixes #70
64e9a9a 
The API for parameterize changed in rails 5.0 and even though other
test cases run through this, we expect(:results_valid?) which effectively
stubs it out entirely so we never hit that code block.
@ericfranz ericfranz merged commit cbb8b19 into master Apr 2, 2020
@ericfranz ericfranz deleted the fix-parameterize branch April 2, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

active_support/core_ext/string/inflections#parameterize API has changed in rails 5.2
2 participants
@johrstrom @ericfranz