Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added uses_gpu flag to Job Info class #753

Merged
merged 20 commits into from
Apr 5, 2022
Merged

Added uses_gpu flag to Job Info class #753

merged 20 commits into from
Apr 5, 2022

Conversation

lukew3
Copy link
Contributor

@lukew3 lukew3 commented Mar 24, 2022

Test cases we want to be sure to cover:

  • gres is nil
  • gres is "" (empty)
  • gres is gpu:v100-32g:2
  • gres is gpu:v100-32g:2,pfsdir:1
  • gres is third-thing:sub-thing:17,gpu:v100-32g:2,pfsdir:1
  • gres is third-thing:sub-thing:17,pfsdir:1,gpu:v100-32g:2
  • gres is gres:gpu:1
  • gres is gres:pfsdir:ess

┆Issue is synchronized with this Asana task by Unito

lib/ood_core/job/info.rb Outdated Show resolved Hide resolved
@lukew3 lukew3 requested a review from johrstrom March 30, 2022 19:24
Co-authored-by: Jeff Ohrstrom <johrstrom@osc.edu>
Co-authored-by: Jeff Ohrstrom <johrstrom@osc.edu>
@lukew3 lukew3 requested a review from johrstrom April 5, 2022 18:20
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we're there.

@johrstrom johrstrom merged commit b311447 into master Apr 5, 2022
@johrstrom johrstrom deleted the uses_gpu_flag branch April 5, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants