Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will have same idea as the
after.sh.erb
used by HPC batch connect apps, the pod won't report asRunning
until the TCP port defined for the pod is actually up. I tried to make the class structure such that we could switch to a HTTP probe instead of TCP just by adding a new class in the future. I opted for TCP probe over HTTP probe because didn't want to have to worry about which path for HTTP probe would respond with 200 status code which could vary greatly between batch connect apps. Using a TCP probe seemed more universal.