Support Kubernetes startupProbe #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
May 28, 2021
| end | ||
| end | ||
|
|
||
| class TCPProbe < Probe |
There was a problem hiding this comment.
I don't think we need the subclass. I think we can just start with 1 class and modify later if required. But you're right about tcp being better than http.
There was a problem hiding this comment.
I merged Probe into TCPProbe so now there is only 1 class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will have same idea as the
after.sh.erbused by HPC batch connect apps, the pod won't report asRunninguntil the TCP port defined for the pod is actually up. I tried to make the class structure such that we could switch to a HTTP probe instead of TCP just by adding a new class in the future. I opted for TCP probe over HTTP probe because didn't want to have to worry about which path for HTTP probe would respond with 200 status code which could vary greatly between batch connect apps. Using a TCP probe seemed more universal.