Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSF adapter returns nil instead of Info object #75

Closed
nickjer opened this issue Jan 25, 2018 · 0 comments
Closed

LSF adapter returns nil instead of Info object #75

nickjer opened this issue Jan 25, 2018 · 0 comments
Assignees
@nickjer
Labels
bug

Comments

@nickjer
Copy link
Contributor

nickjer commented Jan 25, 2018

The Adapter#info method should only return an Info object and not nil. The LSF adapter returns nil here:

ood_core/lib/ood_core/job/adapters/lsf.rb

Line 92 in b80a6ee

job ? info_for_batch_hash(job) : nil

@nickjer nickjer added the bug label Jan 25, 2018
@nickjer nickjer self-assigned this Jan 25, 2018
nickjer pushed a commit that referenced this issue Jan 26, 2018
fix lsf return nil for job info
23abd0c 
Fixes #75
@nickjer nickjer mentioned this issue Jan 26, 2018
Merged
nickjer added a commit that referenced this issue Jan 26, 2018
@nickjer
fix lsf return nil for job info (#76)
f9a8099 
Fixes #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickjer nickjer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickjer