Accessibility fixes #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* One too many opening `<span>` tags * Remove opening `<li>` with no closing tag
TODO? Some apps don't have configuration for locale. Maybe not too important at this point as not everything is entirely localized (e.g. hard-coded text in english). Refs: https://dequeuniversity.com/rules/axe/3.3/html-has-lang?application=AxeChrome
|
This is great! |
treydock
pushed a commit
to treydock/ondemand
that referenced
this pull request
Oct 26, 2019
bin/setup patch for debian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor accessibility fixes and fixing a couple broken HTML elements. Accessibility changes are largely, but not limited to, results from Deque's aXe utility (https://www.deque.com/axe/).