Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow a proxy_server #74

Merged
merged 3 commits into from
Oct 9, 2019
Merged

allow a proxy_server #74

merged 3 commits into from
Oct 9, 2019

Conversation

wdpypere
Copy link
Contributor

@wdpypere wdpypere commented Oct 2, 2019 •
edited
Loading

I am no ruby expert but something like this should resolve #73

@treydock
Copy link
Contributor

treydock commented Oct 2, 2019

You'll also want to update ood-portal-generator/share/ood_portal_example.yml. I'd recommend making note the default is value for servername.

@wdpypere
Copy link
Contributor Author

wdpypere commented Oct 2, 2019

@treydock OK, I'll have a look at the example

@wdpypere
Copy link
Contributor Author

wdpypere commented Oct 2, 2019

The tests fail on CentOS 7 because it can't find rake. is this expected?

@treydock
Copy link
Contributor

treydock commented Oct 2, 2019

It's a known issue. The tests install ondemand-runtime and normally that is version 1.6 but I've pushed 1.7 for testing which isn't compatible with the tests.

@wdpypere wdpypere mentioned this pull request Oct 3, 2019
Closed
@johrstrom
Copy link
Contributor

johrstrom commented Oct 9, 2019 •
edited
Loading

Is there anything holding this up? It seems ok to me given the comments and the default value. @ericfranz do we want this as a part of 6-18?

@ericfranz ericfranz merged commit 7f94af5 into OSC:master Oct 9, 2019
ericfranz added a commit that referenced this pull request Oct 24, 2019
@ericfranz
Merge pull request #74 from OSC/revert_cwd
be72f86 
Remove cwd arg to pty.spawn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treydock treydock treydock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ood-portal-generator should allow for different servername and redirect rules
4 participants
@wdpypere @treydock @johrstrom @ericfranz