Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activejobs: use button for details disclosure #732

Merged

Conversation

ericfranz
Copy link
Contributor

use actual button for job details show/hide, so that it is controllable
using a keyboard

add aria attribute expanded expected by disclosure control
add aria label for button

This results in a slight change in look and feel:

screen 2020-11-10 at 10 48 30 AM

But now since we use a button, you can activate using Enter or Space as expected by https://www.w3.org/TR/wai-aria-practices-1.1/#disclosure and focus on the button:

screen 2020-11-10 at 10 48 47 AM

use actual button for job details show/hide, so that it is controllable
using a keyboard

add aria attribute expanded expected by disclosure control
add aria label for button
@ericfranz
Copy link
Contributor Author

This PR does not address these remaining accessibility issues with using this approach for details views:

  1. aria-controls and specifying an id on the child row
  2. the fact that adding a child row to the table for the details view introduces accessibility issues with working with tables (since screen readers announce row counts and as soon as you add a "child row" that count might be messed up)
  3. the fact that the child row has a single td with a column span and no corresponding table header

A solution to consider is that we switch to opening a modal dialog for the details view of a job.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the bug I described in the other PR still exists. I'll open a separate ticket after this is pulled in.

@ericfranz ericfranz merged commit e168641 into master Nov 10, 2020
@ericfranz ericfranz deleted the enable_keyboard_control_of_activejobs_details_view branch November 10, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants