activejobs: use button for details disclosure #732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use actual button for job details show/hide, so that it is controllable
using a keyboard
add aria attribute expanded expected by disclosure control
add aria label for button
This results in a slight change in look and feel:
But now since we use a button, you can activate using Enter or Space as expected by https://www.w3.org/TR/wai-aria-practices-1.1/#disclosure and focus on the button: