-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly escape user input by using Open3 capture methods #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use Open3.capture3 for rsync instead of backticks
johrstrom
reviewed
Oct 23, 2020
Looks like Open3.capture methods do not like spaces in the arguments. These all fail
|
johrstrom
reviewed
Oct 23, 2020
Open3.capture methods don't appear to deal well with arguments with spaces so revert to backticks with Shellwords.escape for escaping the values added tests to verify the happy trail as well
in controller, move bulk of the create block into begin/rescue and add base error message for any problems check for rsync error and set to path attribute if error message present display all error messages as bullet list at top of form set focus to top of error list of no input valid
This reverts commit 8d01823.
ericfranz
added a commit
that referenced
this pull request
Nov 4, 2020
- use Open3.capture3 for rsync instead of backticks in most cases - dashboard: remove broken 'active_users' feature from developer dashboard - myjobs: stick with rsync and Shellwords.escape for rsync command since using filter argument with Open3.capture3 is problematic - myjobs: fix error reporting on new template page (display all error messages as bullet list at top of form) and fix focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove 'active_users' from developer interface which was broken as of Passenger 6 (and not really used anyways).