Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: ignore cache keys that do not exist #655

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

ericfranz
Copy link
Contributor

To reproduce - take a context.json that stores the cache values of any batch connect app, and modify it to include key value pairs where the key is not an attribute defined in the app.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM. tests through undefined method cacheable?' for nil:NilClass` without the fix.

@ericfranz ericfranz merged commit 801ec0d into master Aug 25, 2020
@ericfranz ericfranz deleted the fix_cacheable_bug branch August 25, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants