Make Native Instructions tab for VNC sessions available for other OOD sites #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msquee
changed the title
msquee
changed the title
ericfranz
reviewed
Aug 4, 2020
apps/dashboard/app/views/batch_connect/sessions/connections/_native_vnc.html.erb
Show resolved
Hide resolved
johrstrom
reviewed
Aug 5, 2020
apps/dashboard/app/views/batch_connect/sessions/connections/_native_vnc.html.erb
Outdated
Show resolved
Hide resolved
* OSC Connect verbiage was removed in favor of templates
* Allow OOD_NATIVE_VNC_LOGIN_HOST to be set (purely for visual improvements)
* Fix Linux connection instructions
If you set `OOD_NATIVE_VNC_LOGIN_HOST` then the command will be auto populated with that host. This is purely for visual improvement and has no impact on the VNC connection at all.
To enable the Native Instructions tab, `ENABLE_NATIVE_VNC` must be set to a truthy value such as `1` or `true`
To override the template for different platforms (Windows, MacOS, Linux):
`views/batch_connect/sessions/connections/_native_vnc_{windows,mac,linux}.html.erb`
msquee
force-pushed
the
update/vnc-native-info
branch
from
e2bb0d9
to
7c6ae3b
Compare
ericfranz
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Native Instructionstab for VNC interactive sessions available. Closes #618If you set
OOD_NATIVE_VNC_LOGIN_HOSTthen the command will be auto populated with that host. This is purely for visual improvement and has no impact on the VNC connection at all.To enable the Native Instructions tab,
ENABLE_NATIVE_VNCmust be set to a truthy value such as1ortrueTo override the template for different platforms (Windows, MacOS, Linux):
views/batch_connect/sessions/connections/_native_vnc_{windows,mac,linux}.html.erbScreenshots (on Windows):
and without
OOD_NATIVE_VNC_LOGIN_HOSTset