Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_sshhost to set #564

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Add default_sshhost to set #564

merged 2 commits into from
Jul 7, 2020

Conversation

matthu017
Copy link
Contributor

(in case envvar DEFAULT_SSHHOST is not in cluster configs)

@matthu017 matthu017 requested a review from ericfranz July 2, 2020 16:34
ericfranz
ericfranz reviewed Jul 2, 2020
View reviewed changes
apps/shell/app.js Outdated Show resolved Hide resolved
@johrstrom johrstrom self-requested a review July 7, 2020 18:47
@johrstrom johrstrom merged commit e14c89e into master Jul 7, 2020
@johrstrom johrstrom deleted the add_default_to_sshhost_whitelist branch July 7, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfranz ericfranz ericfranz left review comments

@johrstrom johrstrom johrstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthu017 @ericfranz @johrstrom