-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow users to change cluster dropdown in the form yml #538
Conversation
* users can change the order (the cluster is usually first) by specifying cluster in the form * if attributes are specified the bc app now respects that config but does not do any validation
So this assumes that Maybe I need to produce some examples, but I was thinking it would be preferable to have the freedom to be able to omit Here is an example. For our future uber batch connect app, one approach to implementing it would be a dropdown chosing Owens, Pitzer, or Ruby, and a radio box to choose "Shared VDI" or "Dedicated Hardware". Now the cluster would be Quick if the radio box was Shared VDI, but if the radio box was "Dedicated Hardware" the cluster would be Owens or Pitzer or Ruby. In this case I'd imagine we would do one of two things.
I might prefer to write Ruby instead of JavaScript in this case and choose the latter. If I chose the former, can I specify cluster as a hidden attribute in the batch connect app? If so, then this PR would support this change. Though I'd say that in this case it would seem superfluous to have to specify at the top of the form |
or form.cluster (with or without attributes.cluster). No validation occurs on form.cluster and it by default is a text field if no attributes are given.
Updated. Validity still requires either I don't believe 1 and 2 are mutually exclusive, but if enabling number 2 we'd lose a lot of validity checks. Either way, it could be discussed in #529. |
So validity serves two purposes right now.
|
clusters if using defined clusters, else it's valid.
Fixes #532
specifying cluster in the form
but does not do any validation